Re: [PATCH bpf-next v5 2/3] bpftool: Don't require a disassembler to dump a JITed program to a file

Next message: Christian Marangi: "[PATCH net-next v4 6/6] net: phy: mediatek: add calibration logic for AN7583"
Previous message: Rosen Penev: "[PATCH] drm/nouveau/fifo: map Kepler video engine contexts non-privileged"
In reply to: Mark Korenberg via B4 Relay: "[PATCH bpf-next v5 2/3] bpftool: Don't require a disassembler to dump a JITed program to a file"
Next in thread: Mark Korenberg via B4 Relay: "[PATCH bpf-next v5 1/3] bpftool: Fix disposal of the LLVM disassembler context"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

From: Quentin Monnet

Date: Tue Nov 03 2026 - 17:20:28 EST

2026-11-03 18:59 UTC+0500 ~ Mark Korenberg via B4 Relay
<devnull+socketpair.gmail.com@xxxxxxxxxx>
> From: Mark Korenberg <socketpair@xxxxxxxxx>
>
> "bpftool prog dump jited PROG file FILE" only writes the JITed image to
> FILE, but do_dump() calls disasm_init() before it parses the arguments,
> so the command fails when bpftool has no disassembler.
>
> Call disasm_init() only when the image is disassembled.
>
> Fixes: 29a9c10e4110 ("bpftool: make libbfd optional")
> Suggested-by: Alexei Starovoitov <ast@xxxxxxxxxx>
> Signed-off-by: Mark Korenberg <socketpair@xxxxxxxxx>

Acked-by: Quentin Monnet <qmo@xxxxxxxxxx>