Re: [PATCH ath-next 2/2] wifi: ath12k: refactor m3 and aux_uc firmware memory handling
From: Baochen Qiang
Date: Tue Nov 03 2026 - 21:02:47 EST
On 11/4/2026 1:26 AM, Madhavan Ganesan wrote:
> ath12k_qmi_m3_free()/ath12k_qmi_m3_load() and
> ath12k_qmi_aux_uc_free()/ath12k_qmi_aux_uc_load() implement identical
> logic for freeing a DMA-coherent firmware memory region and for
> loading firmware into it (reuse existing buffer if large enough,
> otherwise free and reallocate, falling back to a standalone firmware
> file when no embedded data is present).
>
> Factor the common logic into ath12k_qmi_free_mem_region() and
> ath12k_qmi_fw_mem_load(), and have the m3 and aux_uc wrappers call
> into them with the appropriate struct ath12k_fw_mem_region and
> firmware file name. The shared free helper also clears paddr, which
> the previous per-region implementations missed.
I don't see that paddr is cleared in ath12k_qmi_free_mem_region()