Re: [PATCH v9 06/12] x86,fs/resctrl: Move resctrl_arch_round_mon_val() out of line
From: Chen Yu
Date: Tue Nov 03 2026 - 22:17:58 EST
On Tue, Nov 03, 2026 at 08:38:01PM +0000, Ben Horgan wrote:
> Hi Chen,
>
> On 14/10/2026 03:59, Chen Yu wrote:
> > resctrl_arch_round_mon_val() is an inline function in the architecture
> > header. It is only called during resctrl initialization and when user space
> > writes "max_threshold_occupancy", neither of which is a hot path that
> > benefits from inlining.
> >
> > Upcoming ERDT support needs resctrl_arch_round_mon_val() to consult
> > ERDT-specific state. Keeping it inline would force ERDT prototypes into the
> > architecture header, fragmenting the ERDT code across files.
> >
> > Move resctrl_arch_round_mon_val() into monitor.c and declare it in
> > include/linux/resctrl.h alongside the other resctrl_arch_*() calls. Move the
> > MPAM stub from arm_mpam.h into mpam_resctrl.c accordingly.
>
> For the MPAM part:
>
> Acked-by: Ben Horgan <ben.horgan@xxxxxxx>
>
Thanks very much, Ben.
thanks,
Chenyu