Re: [PATCH v1 1/2] perf/core: Include attr.defer_output in is_sb_event()

[Ian Rogers]

On Sun, Oct 25, 2026 at 2:55 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> Events configured with attr.defer_output = 1 receive deferred callchain
> sideband records (PERF_RECORD_CALLCHAIN_DEFERRED) via perf_iterate_sb().
> Include attr->defer_output in is_sb_event() so that such events are
> attached to the sideband event list even when no other sideband flags
> (such as mmap or comm) are enabled on the event.
>
> Fixes: c69993ecdd4d ("perf: Support deferred user unwind")
> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>

Ping. +Steve and Masami

Thanks,
Ian

> ---
>  kernel/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index c4217c996f5a..b43883a42566 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -5347,7 +5347,7 @@ static bool is_sb_event(struct perf_event *event)
>             attr->comm || attr->comm_exec ||
>             attr->task || attr->ksymbol ||
>             attr->context_switch || attr->text_poke ||
> -           attr->bpf_event)
> +           attr->bpf_event || attr->defer_output)
>                 return true;
>
>         return false;
> --
> 2.56.0.307.g5fe7bd680c-goog
>