Re: [PATCH v2 1/1] spi: use dmaengine_desc_set_callback()

From: Krzysztof Kozlowski

Date: Wed Nov 04 2026 - 19:11:06 EST


On 04/11/2026 21:41, Andy Shevchenko wrote:
>>
>> But sure, if we want to play such numbers game, I will be sending
>> reviews for single lines.
>
> I'm not playing anything. The problem is that the patch unites the files that
> have distinct maintainers and unrelated to each other code. That's why in the
> subsystems I maintain, I almost always require to split on per-driver basis.
> Yes, exceptions are possible, but has to be quite rare.

That's independent problem. Patch could be split, but it was not. Since
it was not, receiving end should act accordingly, e.g. when performing
incomplete review of only part of the patch, do not call that entire
patch was reviewed by giving the Rb tag, but give Ack tag.

Best regards,
Krzysztof