Re: [PATCH 1/3] ata: libata-transport: drop the dead GSCR newline check

From: Damien Le Moal

Date: Wed Nov 04 2026 - 22:37:50 EST


On 11/4/26 22:14, shao.mingyin@xxxxxxxxxx wrote:
> From: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
>
> SATA_PMP_GSCR_DWORDS is 128, so "SATA_PMP_GSCR_DWORDS & 3" is always
> zero and the branch is dead. The loop already terminates every fourth
> dword with a newline.
>
> No functional change.
>
> Signed-off-by: Shao Mingyin <shao.mingyin@xxxxxxxxxx>

Looks OK.

Reviewed-by: Damien Le Moal <dlemoal@xxxxxxxxxx>

--
Damien Le Moal
Western Digital Research