Re: [PATCH 2/4] dt-bindings: media: qcom,sm8150-camss: Add SM8150 CAMSS

[Bryan O'Donoghue]

On 04/11/2026 23:16, Vladimir Zapolskiy wrote:
> > +maintainers:
> > +  - Andrew Gigena <mail@xxxxxxxxxxxxxxxx>
> > +
> > +description: |
> > +  The CAMSS IP is a CSI decoder and ISP present on Qualcomm platforms.
> > +
> > +properties:
> > +  compatible:
> > +    const: qcom,sm8150-camss
> > +
> > +  clocks:
> > +    minItems: 42
> > +    maxItems: 42
> > +
> > +  clock-names:
> > +    items:
> > +      - const: camnoc_axi
> > +      - const: camnoc_axi_src
> > +      - const: cpas_ahb
> > +      - const: cphy_rx_src
> > +      - const: csiphy0
> > +      - const: csiphy0_timer
> > +      - const: csiphy0_timer_src
> > +      - const: csiphy1
> > +      - const: csiphy1_timer
> > +      - const: csiphy1_timer_src
> > +      - const: csiphy2
> > +      - const: csiphy2_timer
> > +      - const: csiphy2_timer_src
> > +      - const: csiphy3
> > +      - const: csiphy3_timer
> > +      - const: csiphy3_timer_src
>
> Please switch to the new model of describing and exploiting
> the stand-alone CSI2 PHY devices.
>
> Any CAMSS drivers based on the legacy description of CSIPHYs
> should not be accepted into the upstream.

I mean we are just adding a new define for a SoC here - not a new init 
sequence.

We could move all of sc8280xp, sm8150 and sm8250 to a new driver 
topology but, I don't think that's a reasonable ask for a small change 
like this from a new contributor.

Certainly would welcome the transition given above as a defined and neat 
series but, I don't think there's a need for that to include this SoC in 
100% existing infrastructure.

---
bod