Re: [PATCH 2/2] pinctrl: Add Siflower SF19A2890 pin controller driver

From: kernel test robot

Date: Thu Nov 05 2026 - 07:43:37 EST


Hi Joseph,

kernel test robot noticed the following build warnings:

[auto build test WARNING on f33a24cc012d34f25bb9942681bd478a1757b806]

url: https://github.com/intel-lab-lkp/linux/commits/Joseph-Telaak-via-B4-Relay/dt-bindings-pinctrl-Add-Siflower-SF19A2890-pin-controller/20261104-022117
base: f33a24cc012d34f25bb9942681bd478a1757b806
patch link: https://lore.kernel.org/r/20261104-sf19a2890-pinctrl-v1-2-4bb83afdbacf%40telaak.dev
patch subject: [PATCH 2/2] pinctrl: Add Siflower SF19A2890 pin controller driver
config: sh-allyesconfig (https://download.01.org/0day-ci/archive/20261105/202611052240.0EkLv6im-lkp@xxxxxxxxx/config)
compiler: sh4-linux-gcc (GCC) 16.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20261105/202611052240.0EkLv6im-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202611052240.0EkLv6im-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/pinctrl/pinctrl-sf19a2890.c:27:9: warning: 'REG_PC' redefined
27 | #define REG_PC(pin) ((pin) * 0x8)
| ^~~~~~
In file included from arch/sh/include/asm/ptrace_32.h:5,
from arch/sh/include/uapi/asm/ptrace.h:28,
from arch/sh/include/asm/ptrace.h:14,
from arch/sh/include/asm/elf.h:7,
from include/linux/elf.h:6,
from include/linux/module.h:20,
from drivers/pinctrl/pinctrl-sf19a2890.c:15:
arch/sh/include/uapi/asm/ptrace_32.h:23:9: note: this is the location of the previous definition
23 | #define REG_PC 16
| ^~~~~~


vim +/REG_PC +27 drivers/pinctrl/pinctrl-sf19a2890.c

25
26 /* Pad configuration */
> 27 #define REG_PC(pin) ((pin) * 0x8)
28 #define PC_OEN BIT(7)
29 #define PC_ST BIT(6)
30 #define PC_IE BIT(5)
31 #define PC_PD BIT(4)
32 #define PC_PU BIT(3)
33 #define PC_DS GENMASK(2, 0)
34

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki