Re: [PATCH 1/1] tty: serial: use dmaengine_desc_set_callback()
From: Thierry Reding
Date: Thu Nov 05 2026 - 07:45:55 EST
On Mon, Nov 02, 2026 at 12:54:48PM -0500, Frank.Li@xxxxxxxxxxx wrote:
> From: Frank Li <Frank.Li@xxxxxxx>
>
> Replace open-coded assignments to callback and callback_param fields
> of struct dma_async_tx_descriptor with calls to the
> dmaengine_desc_set_callback() helper across serial drivers.
>
> No functional change intended. Prepare to make struct
> dma_async_tx_descriptor private to the DMA engine.
>
> Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> ---
> drivers/tty/serial/8250/8250_dma.c | 6 ++----
> drivers/tty/serial/8250/8250_mtk.c | 3 +--
> drivers/tty/serial/8250/8250_omap.c | 6 ++----
> drivers/tty/serial/amba-pl011.c | 6 ++----
> drivers/tty/serial/atmel_serial.c | 6 ++----
> drivers/tty/serial/fsl_lpuart.c | 6 ++----
> drivers/tty/serial/imx.c | 6 ++----
> drivers/tty/serial/msm_serial.c | 6 ++----
> drivers/tty/serial/mxs-auart.c | 6 ++----
> drivers/tty/serial/pch_uart.c | 6 ++----
> drivers/tty/serial/samsung_tty.c | 6 ++----
> drivers/tty/serial/serial-tegra.c | 6 ++----
> drivers/tty/serial/sh-sci.c | 9 +++------
> drivers/tty/serial/sprd_serial.c | 3 +--
> drivers/tty/serial/stm32-usart.c | 6 ++----
> 15 files changed, 29 insertions(+), 58 deletions(-)
Reviewed-by: Thierry Reding <treding@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature