Re: [PATCH v2] iio: adc: ad4134: Fix duplicate data_read mux state request
From: Joshua Crofts
Date: Thu Nov 05 2026 - 08:25:06 EST
On Thu, 5 Nov 2026 11:31:20 +0800
Chen Ni <nichen@xxxxxxxxxxx> wrote:
> devm_mux_state_get() is called twice in a row. The second call's result
> is stored directly into st->mux_st[AD4134_DOUT0_INPUT] without error
> checking, and then immediately overwritten by the first call's result.
>
> Remove the duplicate call and check the return value before saving the
> state.
>
> Fixes: f12ecb3e147b ("iio: adc: ad4134: Support SPI 4-wire mode")
> Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
Ideally your Signed-off-by tag should be the last one in the tag
block. No need to resend however, this can be tweaked when applying.
--
Kind regards,
Joshua Crofts