Re: [PATCH v14 04/32] firmware: arm_scmi: Introduce protocol instance notifiers
From: Cristian Marussi
Date: Thu Nov 05 2026 - 13:35:35 EST
On Mon, Oct 19, 2026 at 02:02:03PM -0700, Jonathan Cameron wrote:
> On Fri, 16 Oct 2026 19:55:25 +0100
> Cristian Marussi <cristian.marussi@xxxxxxx> wrote:
>
> > SCMI Protocol notifications are typically used by SCMI drivers to detect
> > and react to particular conditions: this was the assumption and the classic
> > usage scenario upon which the SCMI notification framework was built.
> >
> > Some protocols like Telemetry, though, could be interested in enabling and
> > registering for such notifications: in such a scenario each initialized
> > protocol instance could want to register a common protocol notifier.
> >
> > In order to reuse the existing SCMI Notifications machinery, allow
> > protocols themselves to register for their own notifications and provide
> > their own notifier callbacks.
> >
> > Each protocol, at the end of its initialization phase, can now provide one
> > unique per-protocol-instance notifier block, which will be registered, by
> > the core SCMI stack, on the related notification chain: such notifier will
> > be automatically removed during the protocol de-initialization phase.
> >
> > Signed-off-by: Cristian Marussi <cristian.marussi@xxxxxxx>
> Whilst I'm not that familiar with this code, it seems fine to me
> (i.e. needs more eyes despite the tag)
...indeed Sashiko found a few races in some awkward and rare, albeit possible,
scenarios...despite being functional and tested as it is as of now, it
will need a bit more reasoning.
Thanks,
Cristian