Re: [PATCH] selftests/mount_setattr: build with a 64-bit off_t

[Christian Brauner]

On Tue, 03 Nov 2026 11:39:23 -0500, Sasha Levin wrote:
> With glibc on 32-bit architectures, off_t is 32 bits unless
> _FILE_OFFSET_BITS=64 is defined, so the 2 GB ftruncate() of the ext4
> image gets a negative length and the test fails:
> 
>   mount_setattr_test.c:1048:30: warning: implicit conversion from 'long long' to '__off_t' (aka 'long') changes value from 2147483648 to -2147483648 [-Wconstant-conversion]
> 
> Build the test with -D_FILE_OFFSET_BITS=64.
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] selftests/mount_setattr: build with a 64-bit off_t
      https://git.kernel.org/vfs/vfs/c/8fa19db00bf3