RE: [EXTERNAL] [PATCH] scsi: qedf: Remove unesseary function call

[Nilesh Javali]

Jesse,


From: Jesse Taube <jtaubepe@xxxxxxxxxx> 
Sent: Thursday, October 29, 2026 9:35 PM
To: Martin K. Petersen <martin.petersen@xxxxxxxxxx>
Cc: linux-scsi@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; James E.J. Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>; Nimal Prabudoss I <nprabudo@xxxxxxxxxx>; jmeneghi@xxxxxxxxxx; Nilesh Javali <njavali@xxxxxxxxxxx>; Manish Rangankar <mrangankar@xxxxxxxxxxx>; GR-ETH-Storage-Upstream <GR-ETH-Storage-Upstream@xxxxxxxxxxx>; Jesse Taube <jtaubepe@xxxxxxxxxx>
Subject: [EXTERNAL] [PATCH] scsi: qedf: Remove unesseary function call

The result of `skb_transport_header` was unused. Calling this function warned when `skb_transport_header_was_set` returned false causing a panic on debug kernels. Signed-off-by: Jesse Taube <jtaubepe@ redhat. com> --- drivers/scsi/qedf/qedf_main. c
ZjQcmQRYFpfptBannerStart
Prioritize security for external emails: 
Confirm sender and content safety before clicking links or opening attachments 
  https://us-phishalarm-ewt.proofpoint.com/EWT/v1/CRVmXkqW!tY3Z1f8UYlXatS-ced3a7ljFdyuZqiShD8U84cQDrie6xfl-Cea4s-00pRZgkOAcEQxp3FPrt-DlvgUuwE4NK53b1Rpl$  ‌; 


ZjQcmQRYFpfptBannerEnd
The result of `skb_transport_header` was unused. Calling this function
warned when `skb_transport_header_was_set` returned false causing a
panic on debug kernels.

Signed-off-by: Jesse Taube <mailto:jtaubepe@xxxxxxxxxx>
---
 drivers/scsi/qedf/qedf_main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
index da429b3a4283..f2bc0ac684e0 100644
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -2496,7 +2496,6 @@ static void qedf_recv_frame(struct qedf_ctx *qedf,
 
 	/* Pull the header */
 	hp = (struct fcoe_hdr *)skb->data;
-	fh = (struct fc_frame_header *) skb_transport_header(skb);
 	skb_pull(skb, sizeof(struct fcoe_hdr));
 	fr_len = skb->len - sizeof(struct fcoe_crc_eof);
 
-- 
2.56.0

Thanks for the patch.
Reviewed-by: Nilesh Javali <njavali@xxxxxxxxxxx>