Re: [PATCH net-next 2/3] net: sb1250-mac: Advertise and honor RX checksum offload
From: Daniel Machon
Date: Fri Nov 06 2026 - 04:56:43 EST
> The driver already trusts hardware RX checksum status on supported
> chip revisions, but does not advertise NETIF_F_RXCSUM. Consequently,
> ethtool does not report the offload or allow it to be disabled.
>
> Advertise RX checksum offload in hw_features and enable it by default
> when the existing hardware revision check reports support. Test the
> active feature bit in the receive path before marking a packet as
> CHECKSUM_UNNECESSARY, so disabling RX checksum offload restores software
> verification. Hardware can continue computing checksums while their
> results are ignored.
>
> BCM1250 pass 1 does not support the offload and retains the existing
> software checksum behavior.
>
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>
Reviewed-by: Daniel Machon <daniel.machon@xxxxxxxxxxxxx>