Re: [PATCH v4 02/16] dt-bindings: clock: at91: Split up per SoC partially

[Alexander Dahl]

Hello Krzysztof,

Am Fri, Nov 06, 2026 at 11:57:53AM +0100 schrieb Krzysztof Kozlowski:
> On Thu, Nov 05, 2026 at 12:06:38PM +0100, Alexander Dahl wrote:
> > Before adding even more new indexes creating more holes in the
> > clk at91 drivers pmc_data->chws arrays, split this up.
> > 
> > This is a partial split up only for some of the old PMC definitions.
> > 
> > Binding splitup was proposed for several reasons:
> > 
> > 1) keep the driver code simple, readable, and efficient
> > 2) avoid accidental array index duplication
> > 3) avoid memory waste by creating more and more unused array members.
> > 
> > Old values are kept to not break dts, and to maintain dt ABI.
> > 
> > Link: https://lore.kernel.org/linux-devicetree/20250207-jailbird-circus-bcc04ee90e05@xxxxxxxxxxx/T/#u
> > Signed-off-by: Alexander Dahl <ada@xxxxxxxxxxx>
> > ---
> > 
> > Notes:
> >     v4:
> >     - "re-added" some definitions present in hardware but not used in dt
> >     - reword header comment (at91 -> Microchip) for newer SoCs
> >     - PMC_UTMI was renamed where appropriate according to datasheets
> >     
> >     v3:
> >     - full splitup for all at91 family SoCs instead of just a few
> >     
> >     v2:
> >     - new patch, not present in v1
> > 
> >  .../reset/atmel,at91sam9260-reset.yaml        |  3 ++-
> >  .../bindings/usb/atmel,at91sam9rl-udc.yaml    |  3 ++-
> >  .../dt-bindings/clock/atmel,at91rm9200-pmc.h  | 16 ++++++++++++
> >  .../dt-bindings/clock/atmel,at91sam9260-pmc.h | 16 ++++++++++++
> >  .../dt-bindings/clock/atmel,at91sam9g45-pmc.h | 16 ++++++++++++
> >  .../dt-bindings/clock/atmel,at91sam9n12-pmc.h | 16 ++++++++++++
> >  .../dt-bindings/clock/atmel,at91sam9rl-pmc.h  | 16 ++++++++++++
> >  .../dt-bindings/clock/atmel,at91sam9x5-pmc.h  | 16 ++++++++++++
> >  include/dt-bindings/clock/atmel,sama5d2-pmc.h | 20 ++++++++++++++
> >  include/dt-bindings/clock/atmel,sama5d3-pmc.h | 16 ++++++++++++
> >  include/dt-bindings/clock/atmel,sama5d4-pmc.h | 17 ++++++++++++
> >  .../dt-bindings/clock/microchip,sam9x60-pmc.h | 15 +++++++++++
> >  .../dt-bindings/clock/microchip,sam9x7-pmc.h  | 19 ++++++++++++++
> >  .../clock/microchip,sama7d65-pmc.h            | 26 +++++++++++++++++++
> >  .../dt-bindings/clock/microchip,sama7g5-pmc.h | 23 ++++++++++++++++
> 
> I miss the "split" part. You only added defines, shouldn't you remove
> them from other binding?

This is done later in the series in
[PATCH v4 16/16] dt-bindings: clock: at91: Remove old PMC definitions.

Greets
Alex