Re: [PATCH net-next v7 04/10] net: dsa: realtek: rtl8365mb: set RGMII mode for family D
From: Alvin Šipraga
Date: Fri Nov 06 2026 - 10:21:24 EST
On Fri, Nov 06, 2026 at 03:56:18PM +0100, Mieczyslaw Nalewaj wrote:
> > So maybe just check in the switch registers, when it comes out of reset,
> > whether the default state of MAC4_SEL_EXT1 is 0. If yes then I think we
> > can just ignore this problem altogether, advertise RGMII capability on
> > port 7 (i.e. use EXT1), and be done with it.
>
> I do not have the hardware, so I cannot read the reset default of
> MAC4_SEL_EXT1 myself. Could someone with a board read bit 12 of
> TOP_CON0 (0x1d70) right after reset and confirm it is 0? If it is,
> the check is unnecessary and I will drop it.
If you don't have the HW, how are you testing these patches...?
I think we will need a Tested-by: tag from someone(s) with both a family
C and D to get this series in, if you are unable to test things
yourself.
Please also do not submit anything if it has not been tested. Maybe it
was, but then please get that person's Tested-by and put them on
CC. Otherwise maintainers might merge this assuming it was tested, if
you got the reviews... It is a basic assumption that non-RFC stuff has
been tested when posted to the list.
Kind regards,
Alvin