Re: [PATCH v5 12/15] KVM: arm64: Derive the VM hardware dirty mode from dirty logging
From: Leonardo Bras
Date: Fri Nov 06 2026 - 10:47:17 EST
On Fri, Nov 06, 2026 at 06:46:46PM +0800, Tian Zheng wrote:
>
>
> On 11/2/2026 11:03 PM, Leonardo Bras wrote:
> > On Tue, Sep 29, 2026 at 06:36:52PM +0800, Tian Zheng wrote:
> > > Both HAFDBS and HDBSS flip VTCR_EL2.HD at memslot-update time. Two
> > > independent toggles allow an intermediate HDBSS-set/HD-clear state,
> > > an illegal combination, and need locking against concurrent updates.
> > >
> > > Replace both with kvm_arch_update_hw_dirty_mode(), a pure function
> > > of the static capabilities and the number of logging memslots:
> > >
> > > - logging && HDBSS-capable -> HD|HA|HDBSS
> > > - logging, no HDBSS -> off
> > > - !logging && HAFDBS-cap. -> HD|HA
> >
> > This last one is gone now, so I guess most of this patch has to be
> > reworked, right?
> >
> > Thanks!
> > Leo
>
> Hi Leo,
>
> Yes, the last one is no longer needed as we discussed earlier in [1], so
> I'll rework this patch.
>
Awesome, thanks!
Leo