Re: [PATCH] dt-bindings: mmc: describe the Allwinner A733 eMMC controller

[Andre Przywara]

On Mon,  2 Nov 2026 19:41:55 -0500
Enzo Adriano <enzo.adriano.code@xxxxxxxxx> wrote:

Hi,

> Hi Krzysztof,
> 
> On Mon, Nov 02, 2026 at 08:27:19AM +0100, Krzysztof Kozlowski wrote:
> > On Fri, Oct 30, 2026 at 10:26:47PM -0400, Enzo Adriano wrote:
> >> AI assistance: Codex:gpt-6-astra.
> >
> > Drop, we do not advertise slop companies anymore.
> >
> >>
> >> Assisted-by: LLM
> > Drop
> 
> Will do, here and in my other patches.
> 
> >> This binding is a separate prerequisite for the disabled MMC3 node in
> >
> > How this can be a separate prerequisite? Binding without user is not a
> > prerequisite.
> 
> You're right, it isn't. It should not have been posted apart from its
> user.
> 
> >> the A733 DT v2. It does not add a sunxi-mmc driver match or claim an
> >> operational eMMC path.
> >
> > Hm? Why?
> 
> Because I can't test one. None of my three Cubie A7S boards detects an
> eMMC, and their vendor device trees leave this controller disabled.
> 
> [...]
> 
> >> prerequisite-patch-id: 6fc03bfbd343042dd3b660938fcc09c5e7d48314
> >
> > So this cannot really be tested.
> 
> Agreed. Those IDs came from my local tree and are no use to anyone else.
> 
> I'm withdrawing this patch. André, you asked for the other MMC
> controllers because the IP is the same, but the manual documents a
> different descriptor layout for SMHC3 (A733 User Manual v1.00, tables
> 11-3 to 11-6), and I have no hardware to test it on. The next DT
> revision will describe MMC0-2 and leave SMHC3 out until someone can test
> driver support. If either of you would rather have it described now,
> tell me and I'll put it back, in the same series as its user.

Well, I was merely asking to list all instances that are the same. That
one MMC controller is using a different IP is new, so I wasn't aware of
that.
And we don't submit bindings for something that has no driver and
hasn't been tested. We have been bitten by subtle mistakes in the past,
which lead to broken bindings, so just wait until we have some user for
that. Adding to a binding and DT is always fine to do later.

Cheers,
Andre


> 
> Sorry for the noise.
> 
> Best regards,
> Enzo
>