Re: [PATCH] ALSA: info: Use snprintf() in snd_info_card_create()

[Takashi Iwai]

On Sat, 07 Nov 2026 01:43:37 +0100,
Thorsten Blum wrote:
> 
> While the current code works correctly, replace the unbounded sprintf()
> with snprintf() to bound the formatted string to the str buffer.
> 
> Signed-off-by: Thorsten Blum <blum@xxxxxxxxxx>

Shouldn't we use scnprintf() instead?  Otherwise it may lead to a
compiler warning.


thanks,

Takashi

> ---
>  sound/core/info.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/core/info.c b/sound/core/info.c
> index 023b4736aa6d..b0ed66d0336d 100644
> --- a/sound/core/info.c
> +++ b/sound/core/info.c
> @@ -484,7 +484,7 @@ int snd_info_card_create(struct snd_card *card)
>  	if (snd_BUG_ON(!card))
>  		return -ENXIO;
>  
> -	sprintf(str, "card%i", card->number);
> +	snprintf(str, sizeof(str), "card%i", card->number);
>  	entry = create_subdir(card->module, str);
>  	if (!entry)
>  		return -ENOMEM;