Re: [PATCH 1/4] dt-bindings: iio: light: stk33xx: add power supply support

From: Roman Vivchar

Date: Sat Nov 07 2026 - 19:07:14 EST


On Sunday, November 8th, 2026 at 1:53 AM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:

> On Sat, 07 Nov 2026 22:45:45 +0000
> Roman Vivchar <rva333@xxxxxxxxxxxxxx> wrote:
>
> > Hi Jonathan,
> >
> > On Sunday, November 8th, 2026 at 12:36 AM, Jonathan Cameron <jic23@xxxxxxxxxx> wrote:
> >
> > > On Sun, 08 Nov 2026 00:15:03 +0200
> > > Roman Vivchar via B4 Relay <devnull+rva333.protonmail.com@xxxxxxxxxx> wrote:
> > >
> > > > From: Roman Vivchar <rva333@xxxxxxxxxxxxxx>
> > > >
> > > > On some boards, the chip shares a power rail with other components. If
> > > > that rail is turned off, the chip can't function.
> > > Not sure how the sharing is relevant. Even if shared with nothing
> > > else we need to turn it on. So just mention that on some boards it
> > > isn't always on.
> > >
> > > The only reason this would be optional in the binding is if there
> > > was internal routing in some packaging or similar that meant there
> > > was no pin to connect.
> > >
> > > Upshot, make this required in the binding. Note that doesn't mean
> > > the driver must require it - we are simply documenting that the
> > > device needs power.
> > >
> >
> > I agree this should be required, but that would break dt_binding_check
> > for existing boards. I don't have their schematic nor boards themselves
> > to verify the regulator for the power supply.
>
> There aren't any upstream (from a quick grep) and so not your problem
> unless you have some in a downstream tree that need fixing.

I found these (next-20261015, 7.3-rc7):
$ rg "sensortek,stk" arch/
arch/arm64/boot/dts/exynos/exynos7870-on7xelte.dts
467: compatible = "sensortek,stk3013", "sensortek,stk3310";

arch/arm64/boot/dts/exynos/exynos7870-a2corelte.dts
412: compatible = "sensortek,stk3013", "sensortek,stk3310";

arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts
526: compatible = "sensortek,stk3311";

arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
219: compatible = "sensortek,stk3311";

arch/arm64/boot/dts/mediatek/mt6768-xiaomi-merlin.dts
348: compatible = "sensortek,stk3337", "sensortek,stk3310";

arch/arm64/boot/dts/mediatek/mt6795-sony-xperia-m5.dts
206: compatible = "sensortek,stk3310";

arch/arm64/boot/dts/qcom/msm8916-wiko-chuppito.dts
91: compatible = "sensortek,stk3310";

arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts
173: compatible = "sensortek,stk3310";

arch/arm/boot/dts/qcom/msm8926-sony-xperia-yukon-eagle.dts
169: compatible = "sensortek,stk3310";

> If you do then there is the option of a fixed regulator to close
> the gap. I consider a missing supply a bug that we should fix but maybe
> others disagree.

Yeah in my tree I have added vdd-supply for my board :D

Best regards,
Roman