[PATCH] staging: octeon: remove unnecessary parentheses
From: Oscar Alejandro Sánchez Lucero via B4 Relay
Date: Sun Nov 08 2026 - 07:20:10 EST
From: Oscar Alejandro Sánchez Lucero <aleszlucero@xxxxxxxxx>
Remove unnecessary parentheses around conditional expressions in
ethernet.c to satisfy checkpatch.pl --strict warnings.
Signed-off-by: Oscar Alejandro Sánchez Lucero <aleszlucero@xxxxxxxxx>
---
This single patch cleans up minor checkpatch.pl styling warnings within the core
ethernet logic of the Cavium Octeon staging driver.
1. Remove redundant parentheses around conditional checks inside
cvm_oct_common_change_mtu, cvm_oct_common_set_multicast_list, and
cvm_oct_set_mac_filter.
Oscar Alejandro Sánchez Lucero (1):
staging: octeon: remove unnecessary parentheses
---
drivers/staging/octeon/ethernet.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/staging/octeon/ethernet.c b/drivers/staging/octeon/ethernet.c
index 42ec4b8324a8..f374fdf8f7a9 100644
--- a/drivers/staging/octeon/ethernet.c
+++ b/drivers/staging/octeon/ethernet.c
@@ -262,9 +262,9 @@ static int cvm_oct_common_change_mtu(struct net_device *dev, int new_mtu)
dev->mtu = new_mtu;
- if ((interface < 2) &&
- (cvmx_helper_interface_get_mode(interface) !=
- CVMX_HELPER_INTERFACE_MODE_SPI)) {
+ if (interface < 2 &&
+ cvmx_helper_interface_get_mode(interface) !=
+ CVMX_HELPER_INTERFACE_MODE_SPI) {
int index = INDEX(priv->port);
/* Add ethernet header and FCS, and VLAN if configured. */
int max_packet = new_mtu + mtu_overhead;
@@ -308,9 +308,9 @@ static void cvm_oct_common_set_multicast_list(struct net_device *dev)
struct octeon_ethernet *priv = netdev_priv(dev);
int interface = INTERFACE(priv->port);
- if ((interface < 2) &&
- (cvmx_helper_interface_get_mode(interface) !=
- CVMX_HELPER_INTERFACE_MODE_SPI)) {
+ if (interface < 2 &&
+ cvmx_helper_interface_get_mode(interface) !=
+ CVMX_HELPER_INTERFACE_MODE_SPI) {
union cvmx_gmxx_rxx_adr_ctl control;
int index = INDEX(priv->port);
@@ -360,9 +360,9 @@ static int cvm_oct_set_mac_filter(struct net_device *dev)
union cvmx_gmxx_prtx_cfg gmx_cfg;
int interface = INTERFACE(priv->port);
- if ((interface < 2) &&
- (cvmx_helper_interface_get_mode(interface) !=
- CVMX_HELPER_INTERFACE_MODE_SPI)) {
+ if (interface < 2 &&
+ cvmx_helper_interface_get_mode(interface) !=
+ CVMX_HELPER_INTERFACE_MODE_SPI) {
int i;
const u8 *ptr = dev->dev_addr;
u64 mac = 0;
---
base-commit: ddfe51b0a0f5dc9e415cc2c8ad8db17532dd426b
change-id: 20261108-octeon-parentheses-cleanup-v1-c1f3335a411e
Best regards,
--
Oscar Alejandro Sánchez Lucero <aleszlucero@xxxxxxxxx>