Re: [PATCH] arm64: dts: qcom: sdm845-lg: Fix dark corner in backlight

[David Heidelberg]

On 08/11/2026 21:03, Paul Sajna wrote:
> From: Amir Dahan <system64fumo@xxxxxxx>
>
> Restore qcom,num-strings to the default of 4.
>
> Downstream had qcom,led-strings-list = [00 01 02] set, so for upstream
> we assumed qcom,num-strings was 3. [1]
>
> However downstream also overrides qcom,num-strings to 4 in the driver [2].
>
> Therefore, the correct value is 4, and that value is already the
> default, so we don't need to set it in sdm845-lg-common at all.
>
> [1]: https://github.com/LineageOS/android_kernel_lge_sdm845/blob/lineage-22.2/arch/arm64/boot/dts/lge/sdm845-judy/sdm845-judyln_lao_com/sdm845-judyln_lao_com-panel.dtsi#L29
> [2]: https://github.com/LineageOS/android_kernel_lge_sdm845/blob/lineage-22.2/drivers/leds/leds-qpnp-wled.c#L691

I would likely keep the links under --- as the links are going to live forever, 
but not a showstopper for me :)

> Fixes: c6c66aa3ef33 ("arm64: dts: qcom: sdm845-lg-judyln: Add display panel")
>
> Signed-off-by: Amir Dahan <system64fumo@xxxxxxx>
> Signed-off-by: Paul Sajna <sajattack@xxxxxxxxxxxxxxxx>
> ---
>   arch/arm64/boot/dts/qcom/sdm845-lg-common.dtsi | 1 -
>   1 file changed, 1 deletion(-)
...hard-to-read downstream code, good finding:

Reviewed-by: David Heidelberg <david@xxxxxxx>