Re: [PATCH 2/2] dmaengine: ma35d1-pdma: Add MA35D1 PDMA driver

From: Shan-Chun Hung

Date: Sun Nov 08 2026 - 19:14:48 EST


Dear Uwe,

Thanks for your review.

On 11/7/2026 12:57 AM, Uwe Kleine-König wrote:
Hello,

On Tue, Nov 03, 2026 at 10:22:02AM +0800, Shan-Chun Hung wrote:
+#include <linux/mod_devicetable.h>
[...]
+#include <linux/platform_device.h>

Please don't use <linux/mod_devicetable.h>. <linux/platform_device.h> is
good enough to provide of_device_id already. If you insist on full iwyu,
please use <linux/device-id/of.h> instead.
I will remove it.

Best regards
Uwe

Best Regards,
Shan-Chun