RE: [PATCH net-next v10 11/11] net: phy: ncn26000: Support for loopback

[Selvamani Rajagopal]

> -----Original Message-----
> From: netdev-bot+sashiko@xxxxxxxxxx <netdev-bot+sashiko@xxxxxxxxxx>
> To: Selvamani Rajagopal <Selvamani.Rajagopal@xxxxxxxxxx>
> Subject: Re: [PATCH net-next v10 11/11] net: phy: ncn26000: Support for loopback
> 
> 
 
> Critical: 0 · High: 0 · Medium: 1 · Low: 2
> 
> 
> [Severity: Medium]
> Can the S2500's own config_aneg callback silently clear the loopback bit
> that this sets? genphy_loopback_no_speed() does a read-modify-write of
> BMCR_LOOPBACK only. ncn26000_config_aneg() overwrites the whole register:

Agree. Adding s2500's own config_aneg callback so that existing PHY's behavior won't change
and cause any regression.


> --
> Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-s2500-
> mac-phy-support-v10-0-31b5a69b85b7%40onsemi.com
> <https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261106-s2500-mac-phy-support-v10-0-31b5a69b85b7%40onsemi.com
> etdev-ai.bots.linux.dev>