Re: [PATCH v2 05/12] gpu: nova-core: run the generic bootloader from its own type

[Eliot Courtney]

On Sat Nov 7, 2026 at 6:48 PM JST, Alexandre Courbot wrote:
> From: John Hubbard <jhubbard@xxxxxxxxxx>
>
> The generic falcon bootloader needs a descriptor in DMEM to know what to
> load, so loading it into a falcon means loading the two together by PIO
> and starting the falcon. The FWSEC wrapper did that through its own
> implementation of the PIO loading traits. The r000 load-and-execute
> bootloader event will need to do the same thing.
>
> Give the generic bootloader a run method, which pairs it with the
> descriptor that it receives, loads the pair by PIO, starts the falcon
> with the given MAILBOX0 value and returns the mailboxes once the falcon
> has halted. This will allow the FWSEC and r000 load-and-execute
> bootloader event to share the same code.
>
> No functional changes.
>
> Signed-off-by: John Hubbard <jhubbard@xxxxxxxxxx>
> Co-developed-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> Signed-off-by: Alexandre Courbot <acourbot@xxxxxxxxxx>
> ---

[...]

> diff --git a/drivers/gpu/nova-core/firmware/gen_bootloader.rs b/drivers/gpu/nova-core/firmware/gen_bootloader.rs
> index f769b2b277c0..1fecb6a5f80e 100644
> --- a/drivers/gpu/nova-core/firmware/gen_bootloader.rs
> +++ b/drivers/gpu/nova-core/firmware/gen_bootloader.rs

nit: ctx_dma() accessor can be removed now

Reviewed-by: Eliot Courtney <ecourtney@xxxxxxxxxx>