Re: [PATCH] Input: apm-power - Rename to apm-power-input

[Nicolas Schier]

On Mon, Nov 09, 2026 at 01:25:26AM -0500, Nathan Chancellor wrote:
> When scripts/modules-check.sh is fixed to normalize the module's name
> like name-fix-token does in scripts/Makefile.lib before checking that it
> is unique [1], there is an error due to drivers/input/apm-power.ko and
> drivers/power/supply/apm_power.ko having the same module name.
> 
>   error: the following would cause module name conflict:
>     drivers/input/apm-power.ko
>     drivers/power/supply/apm_power.ko
> 
>   $ modinfo drivers/input/apm-power.ko drivers/power/supply/apm_power.ko | grep name:
>   filename:       drivers/input/apm-power.ko
>   name:           apm_power
>   filename:       drivers/power/supply/apm_power.ko
>   name:           apm_power
> 
> Rename drivers/input/apm-power.c to apm-power-input.c to make the module
> name unique and clear up the error.
> 
> Reported-by: Sasha Levin <sashal@xxxxxxxxxx>
> Closes: https://lore.kernel.org/20261108225808.1809266-1-sashal@xxxxxxxxxx/
> Link: https://lore.kernel.org/20261103110411.11698-1-info@xxxxxxxxxxxxxxxx/ [1]
> Signed-off-by: Nathan Chancellor <nathan@xxxxxxxxxx>
> ---
> We would like to take [1] for 7.5 in kbuild-next, so we would appreciate
> an ack to take this directly or a stable branch that we can pull in.
> ---
>  drivers/input/Makefile                           | 2 +-
>  drivers/input/{apm-power.c => apm-power-input.c} | 0
>  2 files changed, 1 insertion(+), 1 deletion(-)
> 

Thanks!

Reviewed-by: Nicolas Schier <nsc@xxxxxxxxxx>

-- 
Nicolas