Re: [PATCH 2/5] ASoC: dwc: Fix error handling in dw_i2s_set_fmt()

[Maxim Kochetkov]

06.11.2026 14:29, phucduc.bui@xxxxxxxxx wrote:
> From: bui duc phuc <phucduc.bui@xxxxxxxxx>
>
> Return early when an unsupported clock provider format is
> encountered, preventing the function from updating frame_offset
> before returning an error.
>
> Fixes: 221acc16aee1 ("ASoC: dwc: Add TDM mode support")
> Signed-off-by: bui duc phuc <phucduc.bui@xxxxxxxxx>


Reviewed-by: Maxim Kochetkov <fido_max@xxxxxxxx>


>   	switch (fmt & SND_SOC_DAIFMT_FORMAT_MASK) {
> @@ -427,11 +417,11 @@ static int dw_i2s_set_fmt(struct snd_soc_dai *cpu_dai, unsigned int fmt)
>   		dev->frame_offset = 0;
>   		break;
>   	default:
> -		dev_err(dev->dev, "DAI format unsupported");
> +		dev_err(dev->dev, "DAI format unsupported\n");


Should the typo be fixed in a separate commit?