Re: [PATCH 16/17] arm64: dts: qcom: Add initial Halliday dtsi

[Krzysztof Kozlowski]

On 09/11/2026 01:33, Stanislav Aleksandrov wrote:
> Add the device tree for the Qualcomm Halliday SoC
> (SXR2250P / Snapdragon XR2+ Gen 2).
> 
> It describes the CPUs with their idle states, cpufreq and OPP tables,
> the GIC and the PDC, the timers, SCM, SMEM, RPMh with its clocks, power
> domains and interconnects, TLMM, GCC, SPMI, the apps SMMU, USB, UFS
> with ICE, TSENS with the thermal zones and the PMU.
> 
> Signed-off-by: Stanislav Aleksandrov <lightofmysoul@xxxxxxxxx>
> ---
>  arch/arm64/boot/dts/qcom/halliday.dtsi | 1859 ++++++++++++++++++++++++++++++++
>  1 file changed, 1859 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/halliday.dtsi b/arch/arm64/boot/dts/qcom/halliday.dtsi
> new file mode 100644
> index 000000000000..c891913e3cc1
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/halliday.dtsi
> @@ -0,0 +1,1859 @@
> +// SPDX-License-Identifier: BSD-3-Clause

Odd license, suggests you copied it.

> +/*
> + * Copyright (c) 2026, Stanislav Aleksandrov <lightofmysoul@xxxxxxxxx>

You should retain original copyrights as well.

> + */
> +
> +#include <dt-bindings/clock/qcom,halliday-gcc.h>
> +#include <dt-bindings/clock/qcom,rpmh.h>
> +#include <dt-bindings/interconnect/qcom,halliday-rpmh.h>
> +#include <dt-bindings/interconnect/qcom,icc.h>
> +#include <dt-bindings/interconnect/qcom,osm-l3.h>
> +#include <dt-bindings/interrupt-controller/arm-gic.h>
> +#include <dt-bindings/power/qcom,rpmhpd.h>
> +#include <dt-bindings/soc/qcom,rpmh-rsc.h>
> +
> +/ {
> +	interrupt-parent = <&intc>;
> +
> +	#address-cells = <2>;
> +	#size-cells = <2>;
> +
> +	chosen {
> +	};

Drop node.


> +
> +	clocks {
> +		sleep_clk: sleep-clk {
> +			compatible = "fixed-clock";
> +			#clock-cells = <0>;
> +		};
> +
> +		xo_board: xo-board {
> +			compatible = "fixed-clock";
> +			#clock-cells = <0>;
> +		};
> +	};
> +

...

> +
> +	thermal-zones {
> +		aoss0-thermal {
> +			thermal-sensors = <&tsens0 0>;
> +
> +			trips {
> +				aoss0-critical {
> +					temperature = <115000>;
> +					hysteresis = <0>;
> +					type = "critical";
> +				};
> +
> +				aoss0-hot {
> +					temperature = <110000>;
> +					hysteresis = <1000>;
> +					type = "hot";

Oddly ordered. These are sorted by temperature, even if dt-check-style
disagrees.


Best regards,
Krzysztof