[PATCH 1/8] char: xillybus: Use unsigned int literal

From: Eli Billauer

Date: Mon Nov 09 2026 - 06:34:54 EST


Use "1U" rather than "1" left-shift operations in order to avoid signed
integer arithmetic, which has an undefined result if it wraps.

Assisted-by: Sashiko-0.2.5:gemini-3.1-pro-preview
Link: https://sashiko.dev/#/patchset/20260805093436.59740-1-eli.billauer%40gmail.com
Signed-off-by: Eli Billauer <eli.billauer@xxxxxxxxx>
---
drivers/char/xillybus/xillyusb.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/char/xillybus/xillyusb.c b/drivers/char/xillybus/xillyusb.c
index bd3babd39f35..56afb0a577af 100644
--- a/drivers/char/xillybus/xillyusb.c
+++ b/drivers/char/xillybus/xillyusb.c
@@ -381,13 +381,13 @@ static int fifo_init(struct xillyfifo *fifo,

if (log2_size > log2_fifo_buf_size) {
log2_bufnum = log2_size - log2_fifo_buf_size;
- fifo->bufsize = 1 << log2_fifo_buf_size;
+ fifo->bufsize = 1U << log2_fifo_buf_size;
} else {
log2_bufnum = 0;
- fifo->bufsize = 1 << log2_size;
+ fifo->bufsize = 1U << log2_size;
}

- fifo->bufnum = 1 << log2_bufnum;
+ fifo->bufnum = 1U << log2_bufnum;
fifo->size = fifo->bufnum * fifo->bufsize;

if (!fifo->size || /* Unsigned integer overflow */
@@ -516,7 +516,7 @@ static struct xillyusb_endpoint
init_usb_anchor(&ep->anchor);
INIT_WORK(&ep->workitem, work);

- ep->buffer_size = 1 << (PAGE_SHIFT + order);
+ ep->buffer_size = 1U << (PAGE_SHIFT + order);
ep->outstanding_urbs = 0;
ep->drained = true;
ep->wake_on_drain = false;
@@ -1320,7 +1320,7 @@ static int xillyusb_open(struct inode *inode, struct file *filp)
if (rc)
goto late_unopen;

- out_ep->fill_mask = -(1 << chan->out_log2_element_size);
+ out_ep->fill_mask = -(1U << chan->out_log2_element_size);
chan->out_bytes = 0;
chan->flushed = 0;

--
2.17.1