Re: [PATCH v4 1/2] media: ipu-bridge: don't reference the module image from software nodes

From: Laurent Pinchart

Date: Mon Nov 09 2026 - 07:36:54 EST


On Mon, Nov 09, 2026 at 01:43:00PM +0200, Sakari Ailus wrote:
> Hi D.,
>
> On Sat, Oct 10, 2026 at 05:56:25PM +0200, D. Manresa wrote:
> > The software nodes the bridge registers are deliberately never
> > unregistered, so that a later rebind can reuse them. Nothing reachable
> > from them may therefore point into the module image, but two properties
> > still do: the "link-frequencies" values point at cfg->link_freqs in
> > ipu_supported_sensors[], and the "lens-focus" property name is a string
> > literal.
> >
> > Both dangle once the module is unloaded. Re-probing sensor drivers then
> > read poisoned link frequencies from the surviving nodes and fail:
> >
> > ov5693: supported link freq 419200000 not found
> >
> > Copy both into struct ipu_sensor, where the other property names and
> > values already live.
> >
> > Assisted-by: LLM
> > Fixes: 803abec64ef9 ("media: ipu3-cio2: Add cio2-bridge to ipu3-cio2 driver")
> > Fixes: 68b9bcc8a534 ("media: ipu3-cio2: Add support for instantiating i2c-clients for VCMs")
> > Signed-off-by: D. Manresa <dmanresa@xxxxxxxxx>
>
> Could we have a real name here, please?

If you think this patch is important, just drop authorship completely.

--
Regards,

Laurent Pinchart