Re: [PATCH 4/9] device property: provide fwnode_property_get_names()

[Bartosz Golaszewski]

On Mon, Nov 09, 2026 at 01:29:58PM +0100, Alejandro Colomar wrote:
> Hi Bartosz,
> 
> > Date: 2026-11-09 12:16:56+0100
> > From: Bartosz Golaszewski <brgl@xxxxxxxxxx>
> >
> > On Wed, Nov 04, 2026 at 11:17:37PM +0200, Andy Shevchenko wrote:
> > > On Wed, Nov 04, 2026 at 03:03:46PM +0100, Bartosz Golaszewski wrote:
> > > 
> > > > + */
> > > > +int fwnode_property_get_names(const struct fwnode_handle *fwnode, char ***props)
> > > 
> > > Triple indirection is rare. Do we really need it?
> > > 
> > 
> > I don't have a better alternative. Having two functions: one for
> > counting the names and another for retrieving them into a
> > caller-provided array is IMO the worse alternative, so I'd keep it.
> 
> Would it be possible to return the pointer, and then pass the count as
> a parameter?
> 

Is this really better? I think it's less intuitive than just passing a
pointer to an array of strings.

My personal preference is what I did in v1. Unless there are strong
objections, I'd prefer to keep it this way.

Bart