Re: [PATCH] mlxsw: spectrum_ptp: release parsing depth on MTPPPC write failure

[Simon Horman]

On Sat, Nov 07, 2026 at 12:07:17PM +0000, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential
> issue(s) to consider.
> 
> Critical: 0 · High: 1 (1) · Medium: 0 · Low: 0 (1)
> 
> If you believe none of the issues are legitimate, please reply to each
> issue of Medium severity or higher and explain why the AI is wrong.
> If any of them are legitimate and you plan to respin, please let patchwork
> know by including "pw-bot: cr" as a separate line at the end of your reply
> (one such reply per series is enough).
> 
> - [High] The patch fixes the enable-path leak but adds the same leak on
>   the port-removal path.

I believe the issue flagged here is pre-existing. While it does affect this
patch, the patch is still an improvement in its own right. I would
therefore ask for follow-up on the concurrency concern raised here, but I
do not think it should block progress of this patch.

And while the separate bot email, requesting information on how
the problem was found, should be answered, overall this looks good to me.

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>

> 
> Pre-existing issues:
> - [High] This problem wasn't introduced by this patch, but
>   mlxsw_sp1_ptp_mtpppc_update() has no serialization between its two…
> - [Low] The new rollback in mlxsw_sp1_ptp_mtpppc_update()
>   (spectrum_ptp.c:1223-1226) calls mlxsw_sp_parsing_depth_dec().

...