Re: [RFC PATCH v2 03/18] fuse: don't move a folio with PG_rcu_free into a fuse file
From: Linus Torvalds
Date: Mon Nov 09 2026 - 11:47:42 EST
On Mon, 9 Nov 2026 at 08:28, Linus Torvalds
<torvalds@xxxxxxxxxxxxxxxxxxxx> wrote:
>
> On Mon, 9 Nov 2026 at 06:46, David Hildenbrand (Arm) <david@xxxxxxxxxx> wrote:
> >
> > Could we get rid of fuse_try_move_folio() entirely?
>
> Please. That would be great.
.. and in a similar vein, we should get rid of splice doing the same entirely.
Kirly's patch to just remove page_cache_pipe_buf_try_steal() entirely
(ok, it was originally mine, but Kiryl took ownership of that series:
"Tag, you're it") is worth doing, but I think worth doubling down on.
I think we sh ould just get rid of 'try_steal' entirely. I don't think
anybody really uses it. I think it exists in fuse and in the virtio
console, and neither is worth it.
Removing pipe_buf_try_steal() would basically remove all of
fuse_try_move_folio().
Conversely, removing fuse_try_move_folio() would make
pipe_buf_try_steal() even less useful than it is now.
Just remove them both. Good riddance.
Linus