Re: [PATCH net-next v3 1/9] bnxt_en: let the stack segment GSO skbs with too many frags

[Stanislav Fomichev]

> > +#if (MAX_SKB_FRAGS > TX_MAX_FRAGS)
> > +	if (skb_shinfo(skb)->nr_frags > TX_MAX_FRAGS)
> > +		features &= ~NETIF_F_GSO_MASK;
> > +#endif
> 
> [Severity: Low]
> Should this patch have a Fixes: tag?
> 
> Commit b91e82129400 ("bnxt_en: Linearize TX SKB if the fragments exceed
> the max") added the unconditional linearize in bnxt_start_xmit():

[..]

> The commit message describes both problems. Without a Fixes: tag, stable
> kernels that carry b91e82129400 won't pick up this fix.

Will add a Fixes tag, but not sure it's worth the backports..

> [Severity: Low]
> Can the segments that the stack produces here still have more than
> TX_MAX_FRAGS unreadable frags?

[..]

> Could the commit message mention this limitation? Fully closing the gap
> would need a fallback that handles unreadable frags, or a frag limit per
> MSS window at sendmsg time, rather than skb_linearize().

Not sure what's suggested here. The example that's given goes via skb_linearize
and fails cleanly (as expected). Handling this in a better manner is out of
scope?