Re: [PATCH] ata: ahci_dwc: reject invalid device tree port numbers
From: Niklas Cassel
Date: Mon Nov 09 2026 - 14:49:10 EST
On Tue, Nov 10, 2026 at 12:02:34AM +0800, shao.mingyin@xxxxxxxxxx wrote:
> On Mon, Nov 09, 2026 at 04:19:56PM +0100, Niklas Cassel wrote:
> > Again, this warning is reduntant, as it is already printed by
> > ahci_platform_get_resources().
>
> Agreed, and thanks. The KASAN run for this patch printed "invalid port
> number 100" twice in a row, which is exactly the duplication you point
> out; dropping the warning leaves only the skip, which is what the test
> exercises.
>
> > And please send this as a patch 2/2 with the libahci_platform patch as a
> > patch 1/2.
>
> Will do: 1/2 libahci_platform, 2/2 this one. Since the code changes I
> won't carry Damien's v1 Reviewed-by over; he is Cc'd.
I think it is okay to keep his tag, since the only change is a dropped
warning.
Kind regards,
Niklas