Re: [PATCH] keys/trusted/tpm2: rename "bool" to "boolean"
From: Jarkko Sakkinen
Date: Mon Nov 09 2026 - 15:18:47 EST
On Mon, Nov 09, 2026 at 10:08:58PM +0200, Jarkko Sakkinen wrote:
> On Mon, Nov 09, 2026 at 10:48:58PM +0300, Dan Carpenter wrote:
> > On Mon, Nov 09, 2026 at 04:54:13PM +0200, Jarkko Sakkinen wrote:
> > >
> > > Are we migrating to C23? I've not followed this too closely.
> >
> > Google AI says that we will adopt C23 next year or the year after.
> > I argued that it would be would be after 2030 but AI said, "No, there
> > is too much juicy stuff in C23 for kernel developers to wait so long."
> >
> > I don't have a pressing need for this patch to be merged. I was
> > just playing with some compiler related tools noticed this. It's
> > the only place in the kernel which uses "bool" as a variable name.
>
> I do think that bool is not great choice for a variable name; in fact
> it is quite horrible choice. But since there is no other force than being
> horrible name, I think I'll pass...
In order to put this in a proper context, I meant that bad variable
names are common. I'm not blaming patch author in particular,
especially since it is a local variable. It is just something that
happens all the time; occasionally.
We could merge a billion patches like this with no other effect than
causing extra merge conflicts in backports. So the net-effect is
more harm than good.
Br, Jarkko