Re: [PATCH v3 1/4] dt-bindings: media: i2c: st,vd55g1: Add ST VD55G0
From: Krzysztof Kozlowski
Date: Tue Nov 10 2026 - 06:35:02 EST
On Mon, Nov 09, 2026 at 11:28:35AM +0100, Benjamin Mugnier wrote:
> Hi Sergey,
>
> Le 09/11/2026 à 10:34, Sergey Lebedev a écrit :
> > The VD55G0 is a monochrome global shutter sensor with a 644x604 active
> > array, sending over a single MIPI CSI-2 lane, with the same supplies,
> > reset and strobe GPIOs as the VD55G1. Its MIPI rate runs from 750 to
> > 1200 Mbps (UM2829, 13.1), so its link frequency starts at 375 MHz, and
> > its I2C address is set in its NVM rather than fixed.
> >
> > allOf moves below required to carry the if/then for that minimum.
> >
> > Signed-off-by: Sergey Lebedev <lsa.uz@xxxxx>
> > ---
> > v3: no change.
> >
> > v2: the VD55G0 joins this file instead of a st,vd55g0.yaml of its own,
> > with allOf below required for the if/then, as Krzysztof pointed to. It
> > is Peter Marshall's 01/11 and 02/11 of his vd55g1 v2 squashed, as
> > Krzysztof asked there, with the VD55G0's description added:
> > https://lore.kernel.org/all/20260918221705.323510-3-pm@xxxxxxxxxxxxxxxx/
>
> As vd55g1 and vd55g0 are two different drivers I think they should be
We do not split bindings files just because drivers are different. If
bindings for a device are exactly the same - and they are here - they
should be in one file, for simplicity and less of code to maintain.
Best regards,
Krzysztof