Re: [PATCH 02/11] pinctrl: scmi: map the schmitt trigger enable to its SCMI type

[Cristian Marussi]

On Fri, Oct 30, 2026 at 04:58:33PM +0100, Clément Le Goffic wrote:
> PIN_CONFIG_INPUT_SCHMITT_ENABLE was sent as INPUT_MODE, which drives
> the input buffer, and PIN_CONFIG_INPUT_SCHMITT, a threshold, as
> INPUT_SCHMITT, which only takes 0 or 1. Send the enable as
> INPUT_SCHMITT and refuse the threshold, the protocol has no type for
> it.
> 

> Fixes: eb524cb651b7 ("pinctrl: Implementation of the generic scmi-pinctrl driver")
> Signed-off-by: Clément Le Goffic <clegoffic@xxxxxxxxxxxx>
> ---

LGTM.
Reviewed-by: Cristian Marussi <cristian.marussi@xxxxxxx>

Thanks,
Cristian

>  drivers/pinctrl/pinctrl-scmi.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/pinctrl/pinctrl-scmi.c b/drivers/pinctrl/pinctrl-scmi.c
> index 6bc94c68e89a..5de47e060e8c 100644
> --- a/drivers/pinctrl/pinctrl-scmi.c
> +++ b/drivers/pinctrl/pinctrl-scmi.c
> @@ -128,11 +128,8 @@ static int pinctrl_scmi_map_pinconf_type(enum pin_config_param param,
>  	case PIN_CONFIG_INPUT_ENABLE:
>  		*type = SCMI_PIN_INPUT_MODE;
>  		break;
> -	case PIN_CONFIG_INPUT_SCHMITT:
> -		*type = SCMI_PIN_INPUT_SCHMITT;
> -		break;
>  	case PIN_CONFIG_INPUT_SCHMITT_ENABLE:
> -		*type = SCMI_PIN_INPUT_MODE;
> +		*type = SCMI_PIN_INPUT_SCHMITT;
>  		break;
>  	case PIN_CONFIG_MODE_LOW_POWER:
>  		*type = SCMI_PIN_LOW_POWER_MODE;
> 
> -- 
> 2.56.0
>