Re: [PATCH net v2 3/3] net: stmmac: dwmac1000: stop hardware from dropping checksum-error packets

[Jakub Kicinski]

On Wed,  4 Nov 2026 16:19:13 +0100 Christian Schmidbauer wrote:
>  /* DMA operation mode defines (start/stop tx/rx are placed in common header)*/
>  /* Disable Drop TCP/IP csum error */
> +#define DMA_CONTROL_DT		0x04000000

Maybe just me, since I don't know the HW, but what does _DT stand for
in this context? Other bits seem to be documented with a comment,
let's document the new one as well.

Not sure what the comment above the new define is deferring to, either.
Should it be removed?

>  #define DMA_CONTROL_RSF		0x02000000	/* Receive Store and Forward */
>  #define DMA_CONTROL_DFF		0x01000000	/* Disaable flushing */
-- 
pw-bot: cr