Re: [PATCH 1/2] x86/mm: Make highstart_pfn and highend_pfn local to initmem_init()

From: Mike Rapoport

Date: Wed Nov 11 2026 - 12:39:31 EST


On Wed, Nov 11, 2026 at 02:36:34PM +0100, Thorsten Blum wrote:
> Since commit 35c3151a98a6 ("x86/mm: Consolidate initmem_init()") removed
> arch/x86/mm/numa_32.c, highstart_pfn and highend_pfn are only used in
> initmem_init().
>
> Declare both variables locally and remove their unused extern
> declaration. Use min() to initialize highstart_pfn.
>
> No functional change.
>
> Signed-off-by: Thorsten Blum <blum@xxxxxxxxxx>

Acked-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>

> ---
> arch/x86/include/asm/highmem.h | 3 ---
> arch/x86/mm/init_32.c | 8 +++-----
> 2 files changed, 3 insertions(+), 8 deletions(-)

--
Sincerely yours,
Mike.