Re: [PATCH net-next v2] net: phy: aquantia: Poll global status register for provision ID
From: Hongmei Xu
Date: Wed Nov 11 2026 - 22:01:18 EST
On Wed, Nov 11, 2026 at 9:40 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > + else if (ret)
> > + phydev_warn(phydev, "Firmware provisioning ID not ready; "
> > + "interface mode detection may be incorrect\n");
>
> Please don't split strings. Somebody is going to grep for "Firmware
> provisioning ID not ready; interface mode detection may be incorrect"
> when they see it in their logs and not be able to find it.
>
> This is one exception we make to the 80 character rule.
Sure, make sense, will merge the log into one single line.
Regards,
Hongmei Xu