Re: [PATCH v5 1/6] nfc: s3fwrn5: drop of_match_ptr() from the I2C driver
From: Adil Tepe
Date: Mon Nov 16 2026 - 01:26:02 EST
From: Adil Hüsrev Tepe <tadilhusrev@xxxxxxxxx>
Hi Jorijn,
Tested on a Samsung Galaxy XCover5 (Exynos850) on top of 7.4-rc1: the
s3fwrn5 I2C driver probes, binds, and does DEV_UP/START_POLL/DEV_DOWN
cleanly with these preparatory patches applied; the "s3fwrn5_i2c" rename
and the of_match_ptr() removal cause no regression, and the PVDD supply
is enabled as expected (NFC is dead without it on this board).
For patches 1/6, 2/6 and 4/6:
Tested-by: Adil Hüsrev Tepe <tadilhusrev@xxxxxxxxx>
(3/6 is the binding; I can give Reviewed-by there if useful, but I did
not write the binding so I'll leave that to the DT maintainers.)
The variant patch 5/6 needs a clock-rate fix before it works on this
26 MHz board -- details in my reply to that patch.
Assisted-by: LLM
-- Adil Hüsrev Tepe