AW: [PATCH] raid6: use normal stores in the x86 x4 xor_syndrome functions
From: Markus Stockhausen
Date: Mon Nov 16 2026 - 01:39:54 EST
> Von: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Gesendet: Montag, 16. November 2026 07:11
> An: Miroslav Cimerman <mc@xxxxxxxxxxx>
> <markus.stockhausen@xxxxxxxxxxx>
> Betreff: Re: [PATCH] raid6: use normal stores in the x86 x4 xor_syndrome functions
>
> On Mon, Nov 09, 2026 at 03:08:05AM +0000, Miroslav Cimerman wrote:
> > xor_syndrome() updates P and Q in place for a read-modify-write. md
> > calls it twice on the same P/Q page per write, to remove the old data
> > and to add the new data. The x1 and x2 unrolled versions write P and Q
> > with normal stores since commit a582564b24be ("md/raid6 algorithms:
> > xor_syndrome() for SSE2"), which argued that non-temporal stores of
> > less than a cache line are slow, but kept non-temporal stores in the
> > x4 version, as it writes whole cache lines. The AVX2 and AVX-512
> > versions followed the same pattern.
>
> Adding Markus as the author of that commit.
Thanks for the update after a long time. Happy to see that this is still in
place. I had only 2008 hardware at the time of the initial commit. So
all observations might be wrong with newer hardware.
Markus