Re: [PATCH v2 1/4] gpio: aspeed-sgpio: propagate IRQ setup error in probe

From: Krzysztof Kozlowski

Date: Mon Nov 16 2026 - 03:02:54 EST


On 10/11/2026 16:29, shao.mingyin@xxxxxxxxxx wrote:
> From: Shao Mingyin <shao.mingyin@xxxxxxxxxx>
>
> aspeed_sgpio_probe() ignores the return value of
> aspeed_sgpio_setup_irqs(). That function returns the result of
> platform_get_irq(), so on failure - in particular -EPROBE_DEFER while
> the parent interrupt controller is still probing - the driver carries on

How parent controller can defer probing?

This is on of many LLM slops this user sent (and then replied with LLM
replies, so we are talking with a meat proxy).

See https://lore.kernel.org/all/avibe0HG4ssUUuBX@gremlin/ and many others

> and registers the gpiochip with no interrupt support, and the deferred
> probe is never retried, leaving GPIO interrupts permanently broken.
>
> The "interrupts" property is mandatory for this device, so propagate the
> error from probe.
>
> Fixes: 7db47faae79b ("gpio: aspeed: Add SGPIO driver")
> Cc: stable@xxxxxxxxxxxxxxx

Nothing for stable really.


Best regards,
Krzysztof