RE: [PATCH] wifi: rtw89: update PN state only from correctly decrypted frames
From: Ping-Ke Shih
Date: Mon Nov 16 2026 - 03:04:36 EST
Zhao Li <enderaoelyther@xxxxxxxxx> wrote:
> diff --git a/drivers/net/wireless/realtek/rtw89/core.c b/drivers/net/wireless/realtek/rtw89/core.c
> index 58ee5efc3b5e..a173253d51ff 100644
> --- a/drivers/net/wireless/realtek/rtw89/core.c
> +++ b/drivers/net/wireless/realtek/rtw89/core.c
> @@ -3950,7 +3950,8 @@ static bool rtw89_core_skb_pn_valid(struct rtw89_dev *rtwdev,
> if (!ieee80211_is_data_qos(hdr->frame_control))
> return true;
>
> - if (!desc_info->hw_dec || !desc_info->addr1_match)
> + if (!desc_info->hw_dec || desc_info->sw_dec || desc_info->icv_err ||
> + desc_info->crc32_err || !desc_info->addr1_match)
This patch is OK to me, but can you keep existing two conditions unchanged?
Just add three new conditions.
Or any reason you want move addr1_match to be the last one?
> return true;
>
> guard(rcu)();
>
> base-commit: 5dbf2415ca9821a611d09308e3b29d2c37e7cd77
> --
> 2.56.1