Re: [PATCH rtw-next v4 1/7] wifi: rtw88: 8812a, 8814a: enable STBC for HT transmissions
From: Luka Gejak
Date: Mon Nov 16 2026 - 03:07:06 EST
On November 16, 2026 7:54:02 AM GMT+01:00, Jie Feng <hjf3108@xxxxxxxxx>
wrote:
>On Sun, 15 Nov 2026 at 05:35, Luka Gejak <luka.gejak@xxxxxxxxx> wrote:
>>
>> Hi Jie Feng,
>>
>> Thanks for the update. Two comments below.
>>
>> On November 15, 2026 12:43:27 PM GMT+01:00, Ho Jie Feng
><hjf3108@xxxxxxxxx>
>> wrote:
>>
>> > 8812a and 8814a support STBC, enable it.
>>
>> Could you mention here that this enables HT TX STBC on these chips? As
>> far as I can see, VHT TX STBC was already advertised when more than one
>RF
>> path is available, so that would make the scope clearer.
>The commit subject line already mentions HT explicitly, do you think
>it will be better
>to put it again in the description too?
The subject makes the HT scope clear. I think it would still help to
explain that these chips already advertised VHT TX STBC but did not
advertise it for HT. That would give the change a little more context.
>
>> [ ... ]
>>
>> > Tested on RTL8812AU, STBC packets were captured in monitor mode.
>>
>> Were these HT transmissions from the RTL8812AU, for example on 2.4 GHz
>> or with an HT only AP? As far as I can see, we already advertise VHT TX
>> STBC on this chip, so a VHT capture would not confirm the change here.
>Yes it is a HT only AP, I see HT STBC packets in the capture.
>
Thanks, that answers my question.
Best regards,
Luka Gejak