RE: [PATCH 2/2] serial: fsl_lpuart: Enable DMA for TX in console mode

From: Sherry Sun

Date: Mon Nov 16 2026 - 03:15:26 EST


> From: Jonas Juffinger <jonas.juffinger@xxxxxxxxxxxx>
>
> Remove the check that disabled TX DMA if the device is in console mode.
>
> The reason for this check was that break detection cannot be efficiently
> implemented with DMA. See commit 8cac2f6eb854 ("serial: fsl_lpuart:
> disable DMA for console and fix sysrq").
> However, break detection only affects the RX path, not the TX path.
>
> The 8-bit LPUART hardware supports using DMA only for TX and not for RX.
> I do not have a CPU with the 32-bit LPUART hardware to verify that this
> change also work with the 32-bit LPUART. It probably does.

No, it doesn't work for 32-bit LPUART, I've tested it and the console become a
mess with this change. :(

Best Regards
Sherry
>
> Signed-off-by: Jonas Juffinger <jonas.juffinger@xxxxxxxxxxxx>
> ---
> drivers/tty/serial/fsl_lpuart.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c index
> 5817c47e4db3..e569e2c6ffe9 100644
> --- a/drivers/tty/serial/fsl_lpuart.c
> +++ b/drivers/tty/serial/fsl_lpuart.c
> @@ -1765,9 +1765,6 @@ static void lpuart_tx_dma_startup(struct
> lpuart_port *sport)
> u32 uartbaud;
> int ret;
>
> - if (uart_console(&sport->port))
> - goto err;
> -
> if (!sport->dma_tx_chan)
> goto err;
>
>
> --
> 2.43.0
>