Re: [PATCH net-next v2 8/9] ice: dpll: update locking comments

From: Ivan Vecera

Date: Mon Nov 16 2026 - 03:23:13 EST


Sashiko reviewed v2 only on its dashboard [1], with a low severity
finding, so I am answering it here.

[1] https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20261111164021.273409-1-ivecera%40redhat.com

> Is "use three different clock_ids" always true on E825?
[...]
> The conclusion that only @lock serializes everything still holds, since
> fewer domains only add serialization. Could the text say "up to three
> different clock_ids" or "may use different clock_ids" instead?

Right, it is up to three. Only the PF that owns the source timer has the
TSPLL DPLL, and without a valid permanent MAC the TXC DPLL uses
pf->dplls.clock_id as well. The conclusion holds, as you say. I will
change it to "can use different clock_ids" in a respin or a follow-up.

Thanks,
Ivan