Re: [PATCH v5 09/13] drm/bridge: tc358762: Fix sync polarities

From: Andreas Kemnade

Date: Mon Nov 16 2026 - 03:30:08 EST


On Thu, 15 Oct 2026 14:16:00 +0300
Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> wrote:

> Setting LCDCTRL_HSYNC_POL and LCDCTRL_VSYNC_POL will make the respective
> sync signal active high. The driver does this in inverse. Fix it.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx>

at least the commit message matches what the patch does, but nothing else
can be checked anyways here.

Reviewed-by: Andreas Kemnade <andreas@xxxxxxxxxxxx>

> ---
> drivers/gpu/drm/bridge/tc358762.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/tc358762.c b/drivers/gpu/drm/bridge/tc358762.c
> index 1fb5626a35ab..2baacef685a5 100644
> --- a/drivers/gpu/drm/bridge/tc358762.c
> +++ b/drivers/gpu/drm/bridge/tc358762.c
> @@ -190,10 +190,10 @@ static int tc358762_init(struct tc358762 *ctx)
>
> lcdctrl |= LCDCTRL_DCLK_POL;
>
> - if (ctx->mode.flags & DRM_MODE_FLAG_NHSYNC)
> + if (ctx->mode.flags & DRM_MODE_FLAG_PHSYNC)
> lcdctrl |= LCDCTRL_HSYNC_POL;
>
> - if (ctx->mode.flags & DRM_MODE_FLAG_NVSYNC)
> + if (ctx->mode.flags & DRM_MODE_FLAG_PVSYNC)
> lcdctrl |= LCDCTRL_VSYNC_POL;
>
> tc358762_write(ctx, LCDCTRL, lcdctrl);
>