RE: [PATCH v6 0/8] iio: imu: Add support for the ADI ADIS16607
From: Sabau, Radu bogdan
Date: Mon Nov 16 2026 - 03:55:13 EST
> -----Original Message-----
> From: Jonathan Cameron <jic23@xxxxxxxxxx>
> Sent: Saturday, November 14, 2026 2:50 AM
...
> >
> > > This series adds support for the Analog Devices ADIS16607, a precision
> > > MEMS IMU with triaxial gyroscope, triaxial accelerometer, and
> > > temperature sensor, communicating over a non-standard SPI Half-Duplex
> > > protocol.
> >
> > Applied 1-5 to the testing branch of iio.git.
> >
> > I 'think' the proposed changes for the fifo handling shouldn't affect
> > those and I don't fancy reviewing a mega series with library changes
> > and the new device support. So build on the base of these first 5 patches.
> >
> > You will need to provide a base commit for dependency list though
> > or sashiko may get confused.
> >
> Change of plan. Dropped it over channel type issues in patch 5.
Thank you guys again for the review, and sorry about patch 5. I'll move the
scan_index/scan_type and the timestamp channel into the FIFO patch and
resend.
On the FIFO side: adis16475's has_fifo variants register an IIO trigger
today and are used through trigger/current_trigger. Converting them to a
trigger-less kfifo buffer, as discussed for the library, would remove
that attribute on the six ADIS1657x variants, so it is an ABI change on
existing devices. Is that acceptable to you?
If not, the alternative is a smaller fix in adislib: iio_trigger_poll_nested()
for the has_fifo path, plus a prep patch taking the sample timestamp in
the handlers instead of pf->timestamp (the nested path does not run the
pollfunc top half). That keeps the ABI as is, and the adis16607 would
then use the adislib trigger path again.